Conversation
microsoft-github-policy-service
bot
added
the
needs-triage
specs/XamlBindingHelper_Spec.md
Outdated
|
|
||
| ### Remarks | ||
|
|
||
| * `dependencyObject` must not be `null`; an `E_POINTER` error is returned if it is `null`. |
There was a problem hiding this comment.
Return type seems to be void
There was a problem hiding this comment.
Updated it to - If dependencyObject or propertyToSet is null, an exception is thrown by the WinRT layer from the underlying E_POINTER failure
specs/XamlBindingHelper_Spec.md
Outdated
| // Existing members omitted for brevity | ||
|
|
||
| [contract(Microsoft.UI.Xaml.WinUIContract, 10)] | ||
| [static_name("Microsoft.UI.Xaml.ISetterStatics2")] |
There was a problem hiding this comment.
Why ISetterStatics2 is required? I think it can be ISetterStatics only
There was a problem hiding this comment.
ISetterStatics2 is created by codegen likely because ValueProperty is in new contract.
| All `XamlBindingHelper.SetPropertyFrom*` methods require a `DependencyProperty` as their second | ||
| argument (`propertyToSet`). Without a public `DependencyProperty` handle for `Setter.Value`, | ||
| callers cannot use `XamlBindingHelper` to set `Setter.Value` directly — they are forced to box the | ||
| value to `Object` first: |
There was a problem hiding this comment.
May be we should say, boxing would be required to set values to Setter without XamlBindingHelper
| // Existing members omitted for brevity | ||
|
|
||
| [contract(Microsoft.UI.Xaml.WinUIContract, 10)] | ||
| [static_name("Microsoft.UI.Xaml.ISetterStatics2")] |
| without requiring the caller to box the struct to `IInspectable`. | ||
|
|
||
| ```idl | ||
| static void SetPropertyFromCornerRadius( |
There was a problem hiding this comment.
Here it should be SetPropertyFromThickness right?
Also I dont see a section for SetPropertyFromCornerRadius
2 participants
Fixes
PR Type
Please check the type of change your PR introduces:
Description
Current Behavior
New Behavior
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):